Ignore autopickup setting when transfering liquids #55497
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fixes #55492.
Attempting to siphon a liquid into a container with autopickup disabled fails with a debug message.
Describe the solution
Ignore the container's autopickup settings when handling a liquid transfer. If the player intentionally selects a container to fill with liquid, they likely don't care if the autopickup settings forbid it.
Describe alternatives you've considered
Prevent containers with incompatible settings from being displayed in the liquid handling menu (might cause more confusion than it fixes).
Testing
Use repro steps from the issue:
Spawn a jerrycan, a hose, and a vehicle with fuel.
In the jerrycan's autopickup settings, press

d
to disable autopickup.Siphon the fuel from the vehicle into the jerrycan.

Fuel transfer successful.

Additional context