Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore autopickup setting when transfering liquids #55497

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

dseguin
Copy link
Member

@dseguin dseguin commented Feb 19, 2022

Summary

None

Purpose of change

Fixes #55492.
Attempting to siphon a liquid into a container with autopickup disabled fails with a debug message.

Describe the solution

Ignore the container's autopickup settings when handling a liquid transfer. If the player intentionally selects a container to fill with liquid, they likely don't care if the autopickup settings forbid it.

Describe alternatives you've considered

Prevent containers with incompatible settings from being displayed in the liquid handling menu (might cause more confusion than it fixes).

Testing

Use repro steps from the issue:

  1. Spawn a jerrycan, a hose, and a vehicle with fuel.

  2. In the jerrycan's autopickup settings, press d to disable autopickup.
    disable_autopickup

  3. Siphon the fuel from the vehicle into the jerrycan.
    fill_into

  4. Fuel transfer successful.
    msg_log

Additional context

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 19, 2022
@NetSysFire NetSysFire added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things labels Feb 19, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 19, 2022
@kevingranade kevingranade merged commit f889ed9 into CleverRaven:master Feb 20, 2022
@dseguin dseguin deleted the liqfill_ignore_settings branch February 20, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Items: Containers Things that hold other things json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't siphon into containers with autopickup off
3 participants